linux-mips
[Top] [All Lists]

Re: [PATCH 1/6] MIPS: irixelf: fix test unsigned var < 0

To: Roel Kluin <12o3l@tiscali.nl>
Subject: Re: [PATCH 1/6] MIPS: irixelf: fix test unsigned var < 0
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 16 Apr 2008 19:00:59 +0100
Cc: linux-mips@linux-mips.org, lkml <linux-kernel@vger.kernel.org>
In-reply-to: <480558CA.7090800@tiscali.nl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <480558CA.7090800@tiscali.nl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Wed, Apr 16, 2008 at 03:39:22AM +0200, Roel Kluin wrote:

> v is unsigned, cast to signed to evaluate the do_brk() return value,

do_brk() is expected to return its first argument as the result in case
of success.  An error also wasn't getting propagated so some further
fixes were needed for irix_map_prda_page and its caller.  So I'll apply
a different fix.

Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>