linux-mips
[Top] [All Lists]

[PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluate allocate_irqno

To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: [PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluate allocate_irqno()
From: Roel Kluin <12o3l@tiscali.nl>
Date: Wed, 16 Apr 2008 17:09:58 +0200
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, lkml <linux-kernel@vger.kernel.org>
In-reply-to: <20080416091554.GA6026@alpha.franken.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <480559DC.2060807@tiscali.nl> <20080416091554.GA6026@alpha.franken.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.9 (X11/20071031)
Thomas Bogendoerfer wrote:
> On Wed, Apr 16, 2008 at 03:43:56AM +0200, Roel Kluin wrote:
>> irq is unsigned, cast to signed to evaluate the allocate_irqno() return 
>> value,
 
>> +            if ((int) irq < 0)
> 
> Why don't you just make irq and rt_timer_irq an int ?

Ok, thanks, It should be right, but I cannot test this (no hardware).
---
when allocate_irqno() returns a negative error value, but is stored in an
unsigned variable 'irq', the test '(irq < 0)' won't work.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/arch/mips/sgi-ip27/ip27-timer.c b/arch/mips/sgi-ip27/ip27-timer.c
index 25d3baf..9cebc9e 100644
--- a/arch/mips/sgi-ip27/ip27-timer.c
+++ b/arch/mips/sgi-ip27/ip27-timer.c
@@ -158,7 +158,7 @@ static void rt_set_mode(enum clock_event_mode mode,
        }
 }
 
-unsigned int rt_timer_irq;
+int rt_timer_irq;
 
 static irqreturn_t hub_rt_counter_handler(int irq, void *dev_id)
 {
@@ -219,7 +219,7 @@ static void __cpuinit hub_rt_clock_event_init(void)
 
 static void __init hub_rt_clock_event_global_init(void)
 {
-       unsigned int irq;
+       int irq;
 
        do {
                smp_wmb();


<Prev in Thread] Current Thread [Next in Thread>