linux-mips
[Top] [All Lists]

[PATCH 2/6] MIPS: ip27-timer: fix unsigned irq < 0

To: ralf@linux-mips.org
Subject: [PATCH 2/6] MIPS: ip27-timer: fix unsigned irq < 0
From: Roel Kluin <12o3l@tiscali.nl>
Date: Wed, 16 Apr 2008 03:43:56 +0200
Cc: linux-mips@linux-mips.org, lkml <linux-kernel@vger.kernel.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.9 (X11/20071031)
irq is unsigned, cast to signed to evaluate the allocate_irqno() return value,
    
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---   
diff --git a/arch/mips/sgi-ip27/ip27-timer.c b/arch/mips/sgi-ip27/ip27-timer.c
index 25d3baf..3c08afd 100644
--- a/arch/mips/sgi-ip27/ip27-timer.c
+++ b/arch/mips/sgi-ip27/ip27-timer.c
@@ -222,19 +222,19 @@ static void __init hub_rt_clock_event_global_init(void)
        unsigned int irq;
 
        do {
                smp_wmb();
                irq = rt_timer_irq;
                if (irq)
                        break;
 
                irq = allocate_irqno();
-               if (irq < 0)
+               if ((int) irq < 0)
                        panic("Allocation of irq number for timer failed");
        } while (xchg(&rt_timer_irq, irq));
 
        set_irq_chip_and_handler(irq, &rt_irq_type, handle_percpu_irq);
        setup_irq(irq, &hub_rt_irqaction);
 }
 
 static cycle_t hub_rt_read(void)
 {

<Prev in Thread] Current Thread [Next in Thread>