linux-mips
[Top] [All Lists]

[PATCH 1/6] MIPS: irixelf: fix test unsigned var < 0

To: ralf@linux-mips.org
Subject: [PATCH 1/6] MIPS: irixelf: fix test unsigned var < 0
From: Roel Kluin <12o3l@tiscali.nl>
Date: Wed, 16 Apr 2008 03:39:22 +0200
Cc: linux-mips@linux-mips.org, lkml <linux-kernel@vger.kernel.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.9 (X11/20071031)
v is unsigned, cast to signed to evaluate the do_brk() return value,
    
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/arch/mips/kernel/irixelf.c b/arch/mips/kernel/irixelf.c
index 290d8e3..fad2a2a 100644
--- a/arch/mips/kernel/irixelf.c
+++ b/arch/mips/kernel/irixelf.c
@@ -583,15 +583,15 @@ static void irix_map_prda_page(void)
        unsigned long v;
        struct prda *pp;
 
        down_write(&current->mm->mmap_sem);
        v =  do_brk(PRDA_ADDRESS, PAGE_SIZE);
        up_write(&current->mm->mmap_sem);
 
-       if (v < 0)
+       if ((long) v < 0)
                return;
 
        pp = (struct prda *) v;
        pp->prda_sys.t_pid  = task_pid_vnr(current);
        pp->prda_sys.t_prid = read_c0_prid();
        pp->prda_sys.t_rpid = task_pid_vnr(current);
 


<Prev in Thread] Current Thread [Next in Thread>