| To: | Sergei Shtylyov <sshtylyov@ru.mvista.com> |
|---|---|
| Subject: | Re: [PATCH] Au1200: kill IDE driver function prototypes |
| From: | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> |
| Date: | Tue, 15 Apr 2008 22:54:34 +0200 |
| Cc: | linux-mips@linux-mips.org, linux-ide@vger.kernel.org, ralf@linux-mips.org |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; bh=zw6dj2TmuXUgilX8wxf0WBCVWhoVaTax2a68QOmrr0Y=; b=Mxhk9xFsPFB0LLDs2seXfxaM964CIJoC3hkS11o4fynL9xVnnVE2SRuPIsOiswBo61zVwLw0YJu6PaAYmLv9gCTT9fbwLxzTINqZwwkWMMTQVoL710+4jYSl6mEc2zU23rrLS2mPBKedIYMAyF+1c7wFjJPsvgZxAdk6mCDzvpM= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=YajF0rRctlsUgONlIwxyakwJWHOwcUkfz5y+QmHIzRqC3UxQPNYPtSx4Yh6YiDl8kyckbB3hpOmyYpFL7JNHxtOK6Y3G8aZgZNqU5GK/C0VX5NhB6pdOH0dg41QUNcoCvrtTBK2t4F/OY0ABweoooKyFNnjNr++Pt5mYCxx+Edc= |
| In-reply-to: | <200804142228.51987.sshtylyov@ru.mvista.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200804142228.51987.sshtylyov@ru.mvista.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | KMail/1.9.9 |
On Monday 14 April 2008, Sergei Shtylyov wrote: > Fix these warnings emitted when compiling drivers/ide/mips/au1xxx-ide.c: > > include/asm/mach-au1x00/au1xxx_ide.h:137: warning: 'auide_tune_drive' > declared > `static' but never defined > include/asm/mach-au1x00/au1xxx_ide.h:138: warning: 'auide_tune_chipset' > declared > `static' but never defined > > by wiping out the whole "function prototyping" section from the header file > <asm-mips/mach-au1x00/au1xxx_ide.h> as it mostly declared functions that are > already dead in the IDE driver; move the only useful prototype into the > driver. > > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> applied > --- > I'm not sure thru which tree this should go -- probably thru Linux/MIPS one... > > Bart, au1xxx-ide-fix-mwdma-support.patch will probably need to be updated to > remove that added prototype since it won't be needed anymore... I would prefer to merge this patch thru IDE tree because of the above and the fact that it only touches "IDE" files - I hope Ralf is fine with it. > drivers/ide/mips/au1xxx-ide.c | 2 ++ > include/asm-mips/mach-au1x00/au1xxx_ide.h | 18 ------------------ > 2 files changed, 2 insertions(+), 18 deletions(-) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Au1200: IDE driver build fix, Bartlomiej Zolnierkiewicz |
|---|---|
| Next by Date: | [PATCH 1/6] MIPS: irixelf: fix test unsigned var < 0, Roel Kluin |
| Previous by Thread: | [PATCH] Au1200: kill IDE driver function prototypes, Sergei Shtylyov |
| Next by Thread: | Re: [PATCH] Au1200: kill IDE driver function prototypes, Sergei Shtylyov |
| Indexes: | [Date] [Thread] [Top] [All Lists] |