linux-mips
[Top] [All Lists]

Re: [PATCH] Make KGDB compile on UP

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH] Make KGDB compile on UP
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 4 Apr 2008 20:35:51 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <200803202059.37857.sshtylyov@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200803202059.37857.sshtylyov@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Mar 20, 2008 at 08:59:34PM +0300, Sergei Shtylyov wrote:

> Building UP kernel with KGDB enabled produces the following errors and warning
> (fatal due to -Werror in arch/mips/kernel/Makefile):
> 
> In file included from arch/mips/kernel/gdb-stub.c:142:
> include/asm/smp.h:25:1: "raw_smp_processor_id" redefined
> In file included from include/linux/sched.h:69,
>                  from arch/mips/kernel/gdb-stub.c:126:
> include/linux/smp.h:88:1: this is the location of the previous definition
> In file included from arch/mips/kernel/gdb-stub.c:142:
> include/asm/smp.h:62: error: redefinition of 'smp_send_reschedule'
> include/linux/smp.h:102: error: previous definition of 'smp_send_reschedule' 
> was here
> include/asm/smp.h: In function `smp_send_reschedule':
> include/asm/smp.h:65: error: dereferencing pointer to incomplete type
> arch/mips/kernel/gdb-stub.c: At top level:
> arch/mips/kernel/gdb-stub.c:660: warning: 'kgdb_wait' defined but not used
> 
> Fix the errors by not directly including <asm/smp.h> (which is already 
> included
> by <linux/smp.h>) and the warning by enclosing kgdb_wait() in #ifdef 
> CONFIG_SMP.

Applied, thanks.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] Make KGDB compile on UP, Ralf Baechle <=