linux-mips
[Top] [All Lists]

Re: [PATCH] WD33C93: let platform stub override no_sync/fast/dma_mode

To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH] WD33C93: let platform stub override no_sync/fast/dma_mode
From: peter fuerst <post@pfrst.de>
Date: Sat, 22 Mar 2008 00:45:03 +0100 (CET)
Cc: linux-scsi@vger.kernel.org, linux-mips@linux-mips.org, ralf@linux-mips.org, James.Bottomley@HansenPartnership.com
In-reply-to: <20080321230424.GA31455@alpha.franken.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080321212543.6F769C2DF8@solo.franken.de> <Pine.LNX.4.58.0803212302190.564@Indigo2.Peter> <20080321230424.GA31455@alpha.franken.de>
Reply-to: post@pfrst.de
Sender: linux-mips-bounce@linux-mips.org

On Sat, 22 Mar 2008, Thomas Bogendoerfer wrote:

> Date: Sat, 22 Mar 2008 00:04:24 +0100
> From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> To: peter fuerst <post@pfrst.de>
> Cc: linux-scsi@vger.kernel.org, linux-mips@linux-mips.org,
>      ralf@linux-mips.org, James.Bottomley@HansenPartnership.com
> Subject: Re: [PATCH] WD33C93: let platform stub override
>     no_sync/fast/dma_mode
>
> On Fri, Mar 21, 2008 at 11:20:07PM +0100, peter fuerst wrote:
> > ...
>
> this hack is IMHO no longer needed. If the user wants to override no_sync
> via kernel command line, it works as before. If the user doesn't no_sync
> will be 0 (now set in sgiwd93.c before calling wd33c93_init()) and the
> driver will try to do sync transfers for all devices. It works like before.

It works cleaner than before :-)

> Or did I miss something ?

No. As already said, just forget it, i missed to look at the whole patch in 
time.

>
> Thomas
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessary a
> good idea.                                                [ RFC1925, 2.3 ]
>
>

<Prev in Thread] Current Thread [Next in Thread>