linux-mips
[Top] [All Lists]

Re: [PATCH] WD33C93: let platform stub override no_sync/fast/dma_mode

To: peter fuerst <post@pfrst.de>
Subject: Re: [PATCH] WD33C93: let platform stub override no_sync/fast/dma_mode
From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
Date: Sat, 22 Mar 2008 00:04:24 +0100
Cc: linux-scsi@vger.kernel.org, linux-mips@linux-mips.org, ralf@linux-mips.org, James.Bottomley@HansenPartnership.com
In-reply-to: <Pine.LNX.4.58.0803212302190.564@Indigo2.Peter>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080321212543.6F769C2DF8@solo.franken.de> <Pine.LNX.4.58.0803212302190.564@Indigo2.Peter>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
On Fri, Mar 21, 2008 at 11:20:07PM +0100, peter fuerst wrote:
> 
> the code-sequence
> 
>       wd33c93_init(...
>       if (hdata->wh.no_sync == 0xff)
>               hdata->wh.no_sync = 0;
> 
> was put/kept there intentionally - in this very order - to enable
> "nosync" from the command-line!

this hack is IMHO no longer needed. If the user wants to override no_sync
via kernel command line, it works as before. If the user doesn't no_sync
will be 0 (now set in sgiwd93.c before calling wd33c93_init()) and the
driver will try to do sync transfers for all devices. It works like before.
Or did I miss something ?

Thomas

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]

<Prev in Thread] Current Thread [Next in Thread>