linux-mips
[Top] [All Lists]

Re: [PATCH: linux-mips 2.6.24.2]: Move arch/mips/philips to arch/mips/nx

To: Daniel Laird <daniel.j.laird@nxp.com>
Subject: Re: [PATCH: linux-mips 2.6.24.2]: Move arch/mips/philips to arch/mips/nxp
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 28 Feb 2008 09:58:56 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <64660ef00802270316s7164fcf6x5baf67c48029b730@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <64660ef00802270316s7164fcf6x5baf67c48029b730@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Wed, Feb 27, 2008 at 11:16:50AM +0000, Daniel Laird wrote:

I was looking through my mail in chronological order so I noticed the older
revision of your patch first.

So your mail client scambles inline patches:

Applying patch patches/0004-01.patch
patching file arch/mips/Kconfig
Hunk #1 succeeded at 309 (offset -3 lines).
patching file arch/mips/kernel/cpu-probe.c
Hunk #1 succeeded at 780 (offset 9 lines).
Hunk #3 succeeded at 889 (offset 11 lines).
patching file arch/mips/Makefile
Hunk #1 succeeded at 408 (offset -2 lines).
patching file arch/mips/nxp/pnx8550/common/gdb_hook.c
patch: **** malformed patch at line 273: IP3106_UART_FIFO_TXFIFO) >> 16) >= 16)

Some clients can be convinced to be nice to inline patches.  I've
collected some advice at http://www.linux-mips.org/wiki/Mailing-patches.
If _everything_ else fails, use attachments.

> Signed-off-by: daniel.j.laird <daniel.j.laird@nxp.com>

Yep :-)

  Ralf

<Prev in Thread] Current Thread [Next in Thread>