linux-mips
[Top] [All Lists]

Re: Linux MIPS PCI resource sanity check

To: Michael Buesch <mb@bu3sch.de>
Subject: Re: Linux MIPS PCI resource sanity check
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Sat, 16 Feb 2008 13:49:56 +0300
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <200802161139.10791.mb@bu3sch.de>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200802161139.10791.mb@bu3sch.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Michael Buesch wrote:

There's a sanity check in pcibios_enable_resources() that looks like this:

        r = &dev->resource[idx];
        if (!r->start && r->end) {
                printk(KERN_ERR "PCI: Device %s not available because of resource 
collisions\n", pci_name(dev));
                return -EINVAL;
        }

What is this check actually doing?

It makes sure that a PCI resource is allocated (base of 0 means that it's unallocated due to previously detected resource conlict (or some other reason).

It triggers for me on a BCM4318 device which is behind a BCM4710 PCI bridge.
r->start is 0 and r->end is 0x1FFF when this triggers.
If I simply comment out that check the device is detected correctly
and seems to initialize just fine.

   No, that failnig resource should be relocated.

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>