linux-mips
[Top] [All Lists]

Re: [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK
From: Sam Ravnborg <sam@ravnborg.org>
Date: Sat, 2 Feb 2008 19:01:44 +0100
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <20080130141408.GA6116@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080130141408.GA6116@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Wed, Jan 30, 2008 at 02:14:08PM +0000, Ralf Baechle wrote:
> Commit 312b1485fb509c9bc32eda28ad29537896658cb8 made __INIT_REFOK expand
> into .section .section ".ref.text", "ax".  Since the assembler doesn't
> tolerate stuttering in the source that broke all MIPS builds.
> 
> Since with this change Sam downgraded __INIT_REFOK to just a backward
> compat thing and there being only a single use in the MIPS arch code the
> best solution is to delete both of __INIT_REFOK and __INITDATA_REFOK (which
> was equally broken) being unused anyway these can be deleted.
> 
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Thanks Ralf - applied.
And sorry for the MIPS breakage.

        Sam

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK, Sam Ravnborg <=