linux-mips
[Top] [All Lists]

[PATCH][MIPS] Malta: Fix reading the PCI clock frequency on big-endian

To: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: [PATCH][MIPS] Malta: Fix reading the PCI clock frequency on big-endian
From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Date: Tue, 15 Jan 2008 00:27:46 +0300
Cc: Linux-kernel <linux-kernel@vger.kernel.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:organization:user-agent:mime-version:to:cc:subject:content-type:content-transfer-encoding; bh=9gHP/UwVKtlJ1tt5ddt7JSH5pnwBCu06IviSuMwFA1o=; b=QXR+yS08R/WcggWqmbqc05SPfULcP7tgbkW4D7doV9+Hj0Y2bCKtWXTmuBQIgzVrgEQ1afQkJs9Vkz59Iog/Dh8o5u1Hj0W9UVF8vKTpXSkcsR5T6cYIbmOtU/uv67vI35tAKbRIthgiuCPDdh2/GnC9QySmV4n48CbpXS1vvqc=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:organization:user-agent:mime-version:to:cc:subject:content-type:content-transfer-encoding; b=LuyAKMIMMQpWjx2ZOwB/DrBNqxf0b9Ea0Z2vD7U9mLxkhMaIb6mNpDi84fojbyHdBKZpd+vTwJOQHBqeSJnSJ/G1W/KnDxAqGvoMBgYe1E4qGEbic9BJNqY/I5TIlOtDXCxNKL2jU/FFiPIn83swLT371ya+xU7aCC9T+Id4w5w=
Organization: DmVo Home
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.14pre (X11/20071022)
The JMPRS register on Malta boards keeps a 32-bit CPU-endian
value. The readw() function assumes that the value it reads is a
little-endian 16-bit number. Therefore, using readw() to obtain
the value of the JMPRS register is a mistake. This error leads
to incorrect reading of the PCI clock frequency on big-endian
during board start-up.

Change readw() to __raw_readl().

This was tested by injecting a call to printk() and verifying
that the value of the jmpr variable was consistent with current
setting of the JP4 "PCI CLK" jumper.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
---
 arch/mips/mips-boards/malta/malta_setup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/mips-boards/malta/malta_setup.c 
b/arch/mips/mips-boards/malta/malta_setup.c
index 9a2636e..bc43a5c 100644
--- a/arch/mips/mips-boards/malta/malta_setup.c
+++ b/arch/mips/mips-boards/malta/malta_setup.c
@@ -149,7 +149,7 @@ void __init plat_mem_setup(void)
        /* Check PCI clock */
        {
                unsigned int __iomem *jmpr_p = (unsigned int *) 
ioremap(MALTA_JMPRS_REG, sizeof(unsigned int));
-               int jmpr = (readw(jmpr_p) >> 2) & 0x07;
+               int jmpr = (__raw_readl(jmpr_p) >> 2) & 0x07;
                static const int pciclocks[] __initdata = {
                        33, 20, 25, 30, 12, 16, 37, 10
                };
-- 
1.5.3

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH][MIPS] Malta: Fix reading the PCI clock frequency on big-endian, Dmitri Vorobiev <=