linux-mips
[Top] [All Lists]

Re: [patch] pnx8xxx clocksource cleanups

To: "Sergei Shtylyov" <sshtylyov@ru.mvista.com>
Subject: Re: [patch] pnx8xxx clocksource cleanups
From: "Vitaly Wool" <vitalywool@gmail.com>
Date: Sat, 12 Jan 2008 23:40:32 +0300
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=ekxrB6WPXo2tXThk7f9GIetdRHImOtqrqP+XiQChU6E=; b=dXAjDE/hF/fa7cEp67sfqDg4VYwR4dzqKJBD7sceK9s0whV3bO+PY1AWfwDL8sHJHyZKCkC7XayNeZ0/mMdgEhduo8YA1NGkCVXS+Ad+9eUahHn6MCKx6PMGUg9qp1yPOC3W6Waktk4m4/6Zb699tQghXesi7dfQyHI7BL9mrf0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=SVy07FQPsAcRpZfEg/oy4WPHKdQ+KtZx8l76ytAnXK5GdRpq0wcUGaVqHTWL+AX+gEMrXFgAcHvKbOZ0yr1IUivG+RW+DHImgRjLjPk2YmXIxOtdii95/VKnVHd8+wPPG6AKsAa5My4Z7DMsr4Jjrj7dUo/rernuwVlT3vCFM+U=
In-reply-to: <4788F6FE.6000803@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4788BAAC.3020908@gmail.com> <4788F6FE.6000803@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
> > +static inline void timer_ack(void)
> > +{
> > +    write_c0_compare(cpj);
> > +}
>
>     I still don't understand why you need this function at all, and the 'cpj'
> variable as well -- clockevents core will set the comparator to a needed
> value.  Also, I don't see much value in moving that function...

Well, it's explicitly made inline and it has been moved closer to the
calling function.

Vitaly

<Prev in Thread] Current Thread [Next in Thread>