linux-mips
[Top] [All Lists]

Re: [PATCH] Cobalt Qube1 has no serial port so don't use it

To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH] Cobalt Qube1 has no serial port so don't use it
From: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Date: Sat, 12 Jan 2008 13:57:33 +0900
Cc: yoichi_yuasa@tripeaks.co.jp, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20080111232517.C7B9FC2F2B@solo.franken.de>
Organization: TriPeaks Corporation
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080111232517.C7B9FC2F2B@solo.franken.de>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 12 Jan 2008 00:25:17 +0100 (CET)
Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote:

> Because Qube1 doesn't have a serial chip waiting for transmit fifo empty
> takes forever, which isn't a good idea. No prom_putchar/early console
> for Qube1 fixes this.
> 
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

Acked-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>

> ---
> 
>  arch/mips/cobalt/console.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/mips/cobalt/console.c b/arch/mips/cobalt/console.c
> index db330e8..d1ba701 100644
> --- a/arch/mips/cobalt/console.c
> +++ b/arch/mips/cobalt/console.c
> @@ -4,10 +4,15 @@
>  #include <linux/io.h>
>  #include <linux/serial_reg.h>
>  
> +#include <cobalt.h>
> +
>  #define UART_BASE    ((void __iomem *)CKSEG1ADDR(0x1c800000))
>  
>  void prom_putchar(char c)
>  {
> +     if (cobalt_board_id <= COBALT_BRD_ID_QUBE1)
> +             return;
> +
>       while (!(readb(UART_BASE + UART_LSR) & UART_LSR_THRE))
>               ;
>  
> 

<Prev in Thread] Current Thread [Next in Thread>