linux-mips
[Top] [All Lists]

[PATCH] mips: fail if DMA coherency is unspecified

To: linux-mips@linux-mips.org
Subject: [PATCH] mips: fail if DMA coherency is unspecified
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Fri, 11 Jan 2008 11:09:35 -0500
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
Currently, if the DMA coherency is unspecified, you simply get a
warning about no return in a function returning int, which can be
easily overlooked.  This makes sure that if the platform hasn't
specified it, that it will get the required visibility.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 include/asm-mips/mach-generic/dma-coherence.h |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/include/asm-mips/mach-generic/dma-coherence.h 
b/include/asm-mips/mach-generic/dma-coherence.h
index 76e04e7..02492a6 100644
--- a/include/asm-mips/mach-generic/dma-coherence.h
+++ b/include/asm-mips/mach-generic/dma-coherence.h
@@ -34,11 +34,13 @@ static inline void plat_unmap_dma_mem(dma_addr_t dma_addr)
 
 static inline int plat_device_is_coherent(struct device *dev)
 {
-#ifdef CONFIG_DMA_COHERENT
+#if defined(CONFIG_DMA_COHERENT)
        return 1;
-#endif
-#ifdef CONFIG_DMA_NONCOHERENT
+#elif defined(CONFIG_DMA_NONCOHERENT)
        return 0;
+#else
+#error DMA coherency of platform is not defined.
+       return 0xbad;
 #endif
 }
 
-- 
1.5.0.rc1.gf4b6c


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] mips: fail if DMA coherency is unspecified, Paul Gortmaker <=