| To: | WANG Cong <xiyou.wangcong@gmail.com> |
|---|---|
| Subject: | Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Fri, 11 Jan 2008 14:17:54 +0000 |
| Cc: | Sam Ravnborg <sam@ravnborg.org>, Andreas Schwab <schwab@suse.de>, LKML <linux-kernel@vger.kernel.org>, linux-kbuild@vger.kernel.org, Andrew Morton <akpm@osdl.org>, linux-mips@linux-mips.org |
| In-reply-to: | <20080102062135.GE2493@hacking> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20080101071311.GA2496@hacking> <20080101072238.GC2496@hacking> <20080101101540.GB28913@uranus.ravnborg.org> <jefxxhlkxb.fsf@sykes.suse.de> <20080101175754.GC31575@uranus.ravnborg.org> <20080102062135.GE2493@hacking> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Wed, Jan 02, 2008 at 02:21:36PM +0800, WANG Cong wrote: > >> Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? > >It would be better to use $(LINUXINCLUDE) as we then pull in all config > >symbols too and do not have to hardcode kbuild internal names (include2). > > OK. Refine this patch. LDSCRIPT also needed fixing to get builds in a separate object directory working again. I've applied below fix. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] mips: picvue: pvc_sem semaphore to mutex, Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH] mips: picvue: pvc_sem semaphore to mutex, Daniel Walker |
| Previous by Thread: | Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, Sam Ravnborg |
| Next by Thread: | Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, Sam Ravnborg |
| Indexes: | [Date] [Thread] [Top] [All Lists] |