Re: [PATCH] METH: fix MAC address handling

[tsbogend@alpha.franken.de (Thomas Bogendoerfer)]

On Sun, Jan 06, 2008 at 12:23:05AM -0800, David Miller wrote:
> > +   u64 macaddr;
> >  
> > -   for (i = 0; i < 6; i++)
> > -           dev->dev_addr[i] = o2meth_eaddr[i];
> >     DPRINTK("Loading MAC Address: %s\n", print_mac(mac, dev->dev_addr));
> > -   mace->eth.mac_addr = (*(unsigned long*)o2meth_eaddr) >> 16;
> > +   macaddr = 0;
> > +   for (i = 0; i < 6; i++)
> > +           macaddr |= dev->dev_addr[i] << ((5 - i) * 8);
> > +
> > +   mace->eth.mac_addr = macaddr;
> >  }
> >  
> >  /*
> 
> Can you double-check that this conversion is equivalent.

yes, I did.

> I know that this whole driver is full of assumptions about
> the endianness of the system this chip is found on, so
> I'm only interested in if the transformation is equivalent
> and the driver will keep working properly.

I've tested the driver and it's still working :-)

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]