| To: | Sam Ravnborg <sam@ravnborg.org> |
|---|---|
| Subject: | (Try #2) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles |
| From: | WANG Cong <xiyou.wangcong@gmail.com> |
| Date: | Tue, 1 Jan 2008 21:11:02 +0800 |
| Cc: | WANG Cong <xiyou.wangcong@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, LKML <linux-kernel@vger.kernel.org>, linux-kbuild@vger.kernel.org, Andrew Morton <akpm@osdl.org>, linux-mips@linux-mips.org |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=t5rV21il7smesmoZ8GpLTmiJgChFHrDhLeALgFpQ/ug=; b=ExqsiH2aAfb8UbQ3kiq3f1G4QRHg/6EzqGL8gr3b2w+SNaRvSt4MfVpD6TgorXeW+UUR1Inz+GYPVNqFvcUf21byLVfxj12pJsD6jv6MG4254NEO/EGYpnAn8rbkRSUtprTXv6pfWBHxvHjRoQfDn//+wliBeKH+By43mTMZKz4= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=udN6VnSNWLOlWiBlzo0kJU86GL+gZ/ZtpS9j6RQoirtijOzmMueqfLwsnDwEZe6dZIyxvYgUPZXgi/naEmPxIz1MquDQQISiNT3zCnQffu651uxAiFT6/1W/DyyJqbYKNOyTRriNaupCAJRnC7n2JkZFd6ghsw69q0+cs96Z1RQ= |
| In-reply-to: | <20080101101540.GB28913@uranus.ravnborg.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20080101071311.GA2496@hacking> <20080101072238.GC2496@hacking> <20080101101540.GB28913@uranus.ravnborg.org> |
| Reply-to: | WANG Cong <xiyou.wangcong@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.14 (2007-02-12) |
>> -KERNEL_IMAGE = $(TOPDIR)/vmlinux
>> +KERNEL_IMAGE = $(objtree)/vmlinux
>
>Current directory when building is $(objtree) so here we should
>just skip the use of TOPDIR like this:
>> +KERNEL_IMAGE = vmlinux
>
>
>> KERNEL_START = $(shell $(NM) $(KERNEL_IMAGE) | grep " _text" | cut -f1 -d\ )
>> KERNEL_ENTRY = $(shell $(NM) $(KERNEL_IMAGE) | grep kernel_entry | cut -f1
>> -d\ )
>>
>> @@ -24,7 +24,7 @@ HEAD_DEFINES := -D_kernel_start=0x$(KERNEL_START) \
>> -D TIMESTAMP=$(shell date +%s)
>>
>> $(obj)/head.o: $(obj)/head.S $(KERNEL_IMAGE)
>> - $(CC) -fno-pic $(HEAD_DEFINES) -I$(TOPDIR)/include -c -o $@ $<
>> + $(CC) -fno-pic $(HEAD_DEFINES) -I$(objtree)/include -c -o $@ $<
>This has never worked with O=.. builds.
>The correct fix here is to use:
>> + $(CC) -fno-pic $(HEAD_DEFINES) -Iinclude -Iinclude2 -c -o $@ $<
>
>The -Iinclude2 is only for O=... builds so to keep current
>behaviour removing $(TOPDIR)/ would do it.
Thank you for your explanations!
The following one corrects all the mistakes as you told.
------->
Since TOPDIR is obsolete, this patch removes TOPDIR
from the Mips Makefiles.
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
---
diff --git a/arch/mips/lasat/image/Makefile b/arch/mips/lasat/image/Makefile
index 5332449..1ae73ce 100644
--- a/arch/mips/lasat/image/Makefile
+++ b/arch/mips/lasat/image/Makefile
@@ -12,7 +12,7 @@ endif
MKLASATIMG = mklasatimg
MKLASATIMG_ARCH = mq2,mqpro,sp100,sp200
-KERNEL_IMAGE = $(TOPDIR)/vmlinux
+KERNEL_IMAGE = vmlinux
KERNEL_START = $(shell $(NM) $(KERNEL_IMAGE) | grep " _text" | cut -f1 -d\ )
KERNEL_ENTRY = $(shell $(NM) $(KERNEL_IMAGE) | grep kernel_entry | cut -f1 -d\
)
@@ -24,7 +24,7 @@ HEAD_DEFINES := -D_kernel_start=0x$(KERNEL_START) \
-D TIMESTAMP=$(shell date +%s)
$(obj)/head.o: $(obj)/head.S $(KERNEL_IMAGE)
- $(CC) -fno-pic $(HEAD_DEFINES) -I$(TOPDIR)/include -c -o $@ $<
+ $(CC) -fno-pic $(HEAD_DEFINES) -Iinclude -Iinclude2 -c -o $@ $<
OBJECTS = head.o kImage.o
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, Sam Ravnborg |
|---|---|
| Next by Date: | Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, Andreas Schwab |
| Previous by Thread: | Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, Sam Ravnborg |
| Next by Thread: | Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, Andreas Schwab |
| Indexes: | [Date] [Thread] [Top] [All Lists] |