| To: | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Subject: | Re: [PATCH] SC26XX: New serial driver for SC2681 uarts |
| From: | Andy Whitcroft <apw@shadowen.org> |
| Date: | Fri, 21 Dec 2007 17:36:01 +0000 |
| Cc: | Thomas Bogendoerfer <tsbogend@alpha.franken.de>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Alan Cox <alan@lxorguk.ukuu.org.uk> |
| In-reply-to: | <20071203155317.772231f9.akpm@linux-foundation.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20071202194346.36E3FDE4C4@solo.franken.de> <20071203155317.772231f9.akpm@linux-foundation.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.13 (2006-08-11) |
On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote:
> > +#define READ_SC(p, r) readb ((p)->membase + RD_##r)
> > +#define WRITE_SC(p, r, v) writeb ((v), (p)->membase + WR_##r)
>
> No space before the (. checkpatch misses this.
Yep, over careful in the special case for the parameters for #define
macros, which have different spacing rules. This will be fixed in 0.13:
WARNING: no space between function name and open parenthesis '('
#1: FILE: Z45.c:1:
+#define WRITE_SC(p, r, v) writeb ((v), (p)->membase + WR_##r)
-apw
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH][MIPS] fix user_cpus_allowed assignment, Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH] SC26XX: New serial driver for SC2681 uarts, Pekka Enberg |
| Previous by Thread: | Re: [PATCH] SC26XX: New serial driver for SC2681 uarts, Pekka Enberg |
| Next by Thread: | Rename Sibyte duart devices?, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |