linux-mips
[Top] [All Lists]

Re: [PATCH 1/4] Introduced GPI_RM9000 configuration parameter

To: Thomas Koeller <thomas.koeller@baslerweb.com>
Subject: Re: [PATCH 1/4] Introduced GPI_RM9000 configuration parameter
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 18 Dec 2007 11:52:54 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20071218003140.4415847A63@mail.koeller.dyndns.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20071218003140.4415847A63@mail.koeller.dyndns.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Tue, Dec 18, 2007 at 01:26:19AM +0100, Thomas Koeller wrote:

> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index c6fc405..62bc553 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -856,6 +856,9 @@ config GENERIC_ISA_DMA_SUPPORT_BROKEN
>  config GENERIC_GPIO
>       bool
>  
> +config GPI_RM9000
> +       bool
> +
>  #
>  # Endianess selection.  Sufficiently obscure so many users don't know what to
>  # answer,so we try hard to limit the available choices.  Also the use of a
> @@ -927,6 +930,7 @@ config MIPS_TX3927
>  config MIPS_RM9122
>       bool
>       select SERIAL_RM9000
> +     select GPI_RM9000

See my earlier reply to 
http://www.linux-mips.org/cgi-bin/mesg.cgi?a=linux-mips&i=20070911122005.GC24679%40linux-mips.org

Technically the patch is ok but please only introduce new config symbols
only together with an actual user.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>