linux-mips
[Top] [All Lists]

Re: [PATCH] SGISEEQ: use cached memory access to make driver work on IP2

To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH] SGISEEQ: use cached memory access to make driver work on IP28
From: Jeff Garzik <jgarzik@pobox.com>
Date: Sat, 01 Dec 2007 16:57:11 -0500
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20071126223934.84BE7C2B26@solo.franken.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20071126223934.84BE7C2B26@solo.franken.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.9 (X11/20071115)
Thomas Bogendoerfer wrote:
Following patch is clearly 2.6.25 material and is needed to get SGI IP28
machines supported.

Thomas.

SGI IP28 machines would need special treatment (enable adding addtional
wait states) when accessing memory uncached. To avoid this pain I changed
the driver to use only cached access to memory.

Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

applied. As I have noted to you previously, /please/ put extraneous comments /after/ a "---" separator, so that they are not copied by git-am (Linus's email patch import tool) into the permanent kernel changelog.

The above should look like:

<snip>
SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to use only cached access to memory.

Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
Following patch is clearly 2.6.25 material and is needed to get SGI IP28 machines supported.

Thomas.

drivers/net/sgiseeq.c | 239 ++++++++++++++++++++++++++++++++++---------------
 1 files changed, 166 insertions(+), 73 deletions(-)
</snip>


See Documentation/SubmittingPatches for more details, in particular "14) The canonical patch format" or http://linux.yyz.us/patch-format.html

        Jeff



<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] SGISEEQ: use cached memory access to make driver work on IP28, Jeff Garzik <=