linux-mips
[Top] [All Lists]

Re: [PATCH] IP28: added cache barrier to assembly routines

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] IP28: added cache barrier to assembly routines
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 28 Nov 2007 14:48:14 +0000
Cc: tsbogend@alpha.franken.de, linux-mips@linux-mips.org
In-reply-to: <20071128.234142.106261815.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20071126223955.9BAAAC2B26@solo.franken.de> <20071128.234142.106261815.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Wed, Nov 28, 2007 at 11:41:42PM +0900, Atsushi Nemoto wrote:

> On Sun, 25 Nov 2007 11:47:56 +0100, Thomas Bogendoerfer 
> <tsbogend@alpha.franken.de> wrote:
> > IP28 needs special treatment to avoid speculative accesses. gcc
> > takes care for .c code, but for assembly code we need to do it
> > manually.
> > 
> > This is taken from Peter Fuersts IP28 patches.
> > 
> > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > ---
> >  arch/mips/lib/memcpy.S       |   10 ++++++++++
> >  arch/mips/lib/memset.S       |    5 +++++
> >  arch/mips/lib/strncpy_user.S |    1 +
> >  include/asm-mips/asm.h       |    8 ++++++++
> >  4 files changed, 24 insertions(+), 0 deletions(-)
> 
> I do not know details of this patch at all, but in general,
> memcpy-inatomic.S and csum_pertial.S are candidates if you changed
> memcpy.S.

tlbex.c may also need modifications.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>