linux-mips
[Top] [All Lists]

Re: [PATCH] SGIWD93: use cached memory access to make driver work on IP2

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] SGIWD93: use cached memory access to make driver work on IP28
From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
Date: Tue, 27 Nov 2007 10:01:39 +0100
Cc: linux-scsi@vger.kernel.org, linux-mips@linux-mips.org, ralf@linux-mips.org, James.Bottomley@HansenPartnership.com
In-reply-to: <Pine.LNX.4.64.0711270927370.22167@anakin>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20071126223921.A566CC2B26@solo.franken.de> <Pine.LNX.4.64.0711270927370.22167@anakin>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
On Tue, Nov 27, 2007 at 09:28:14AM +0100, Geert Uytterhoeven wrote:
> >  struct hpc_chunk {
> >     struct hpc_dma_desc desc;
> > -   u32 _padding;   /* align to quadword boundary */
> > +   u32 _padding[128/4 - 3];        /* align to biggest cache line size */
>                      ^^^^^^^^^
> (128 - sizeof(struct hpc_dma_desc))/4?

yes, that's safer. Thank you.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]

<Prev in Thread] Current Thread [Next in Thread>