linux-mips
[Top] [All Lists]

Re: [PATCH] SGIWD93: use cached memory access to make driver work on IP2

To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH] SGIWD93: use cached memory access to make driver work on IP28
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 27 Nov 2007 09:28:14 +0100 (CET)
Cc: linux-scsi@vger.kernel.org, linux-mips@linux-mips.org, ralf@linux-mips.org, James.Bottomley@HansenPartnership.com
In-reply-to: <20071126223921.A566CC2B26@solo.franken.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20071126223921.A566CC2B26@solo.franken.de>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 26 Nov 2007, Thomas Bogendoerfer wrote:
> --- a/drivers/scsi/sgiwd93.c
> +++ b/drivers/scsi/sgiwd93.c
> @@ -33,19 +33,27 @@
>  
>  struct ip22_hostdata {
>       struct WD33C93_hostdata wh;
> -     struct hpc_data {
> -             dma_addr_t      dma;
> -             void            *cpu;
> -     } hd;
> +     dma_addr_t dma;
> +     void *cpu;
> +     void *dev;
>  };
>  
>  #define host_to_hostdata(host) ((struct ip22_hostdata *)((host)->hostdata))
>  
>  struct hpc_chunk {
>       struct hpc_dma_desc desc;
> -     u32 _padding;   /* align to quadword boundary */
> +     u32 _padding[128/4 - 3];        /* align to biggest cache line size */
                     ^^^^^^^^^
(128 - sizeof(struct hpc_dma_desc))/4?

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>