linux-mips
[Top] [All Lists]

Re: [MIPS] irq_cpu: use handle_percpu_irq handler to avoid dropping inte

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [MIPS] irq_cpu: use handle_percpu_irq handler to avoid dropping interrupts.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 22 Nov 2007 17:23:41 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <20071122161935.GA6605@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <S20032632AbXKOURg/20071115201736Z+24020@ftp.linux-mips.org> <20071123.004132.61510296.anemo@mba.ocn.ne.jp> <20071122161935.GA6605@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Nov 22, 2007 at 04:19:35PM +0000, Ralf Baechle wrote:

> > This might broke probe_irq_on()/probe_irq_off(), since
> > handle_percpu_irq() does not check IRQ_WAITING bit.
> 
> Ok - but does that matter at all?  IRQ probing is only used with ISA
> drivers and for those there will be another interrupt controller such as
> a i8259 PIC daisy chained to one of the CPU interrupt pins.

Ah, I think I now understand the problem.

Seems like no interrupt should ever use IRQ_NOPROBE except ISA interrupts
but unfortunately that flag is not everywhere where it should.  Maybe the
logic should even be negated and the flag become IRQ_PROBE ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>