| To: | "Maciej W. Rozycki" <macro@linux-mips.org> |
|---|---|
| Subject: | Re: Preliminary patch for ip32 ttyS* device |
| From: | Martin Michlmayr <tbm@cyrius.com> |
| Date: | Sat, 17 Nov 2007 20:35:29 +0100 |
| Cc: | Giuseppe Sacco <giuseppe@eppesuigoccas.homedns.org>, mips kernel list <linux-mips@linux-mips.org> |
| In-reply-to: | <Pine.LNX.4.64N.0711071716470.14970@blysk.ds.pg.gda.pl> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20071030214015.050b7950.giuseppe@eppesuigoccas.homedns.org> <20071031130828.GE14187@linux-mips.org> <1194446585.5849.21.camel@scarafaggio> <Pine.LNX.4.64N.0711071716470.14970@blysk.ds.pg.gda.pl> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.16 (2007-06-11) |
* Maciej W. Rozycki <macro@linux-mips.org> [2007-11-07 17:21]: > > If mapbase isn't mandatory, the second part of my patch is > > probably right and fixes a bug. > > You ought to use mapbase and ioremap() with new code as you are not > allowed to use readb()/writeb()/etc. on addresses obtained otherwise > than by calling ioremap(). The use of request_mem_region(), etc. is > not strictly mandatory, but it is nice to have. Many serial drivers > use these functions, so I cannot see a reason why it would be a > hassle for ip32. Can someone propose a patch? It's quote unfortuntely that serial on IP32 is still broken (including 2.6.23). -- Martin Michlmayr http://www.cyrius.com/ |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Cannot unwind through MIPS signal frames with ICACHE_REFILLS_WORKAROUND_WAR, Franck Bui-Huu |
|---|---|
| Next by Date: | [PATCH, REPOST] Fix/Rewrite of the mipsnet driver, Thiemo Seufer |
| Previous by Thread: | Re: Preliminary patch for ip32 ttyS* device, Maciej W. Rozycki |
| Next by Thread: | [PATCH (2.6.25) 2/2] suspend: clean up Kconfig, Johannes Berg |
| Indexes: | [Date] [Thread] [Top] [All Lists] |