linux-mips
[Top] [All Lists]

Re: [PATCH] Introduce __fill_user() and kill __bzero() [take #2]

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] Introduce __fill_user() and kill __bzero() [take #2]
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Thu, 15 Nov 2007 22:16:23 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Thiemo Seufer <ths@networkno.de>, linux-mips <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; bh=zkBxyQzYkDvKnJyvu2batJvPxTh+apCWIOHxywC6GGo=; b=O4hKEiUJw3Uo8ullcYeneO8NKKZkwBOEtEEWU+YOjZHhhOfq5kQBje+jR+efpbDLBSzOXT5UGsffUOqCRFiR0vpk4w4ziqpOL6WKuVMbUrfxyRIpbkv9OaaelyJsDrlAyZHXkG37THaO6ZaTo8QprcTxtak85WT2NKkwn/lI2sQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=rPhic0jnwHpQYVndFYTrlZIp1SwpDeUQqMrpxuboCO/wbl/aFcksRz7KS1rK3JS9I3mX3UK2XLGwT+ux/jMJ2p2TjfxrzA35+3VJ8ea6PwshkYwQNdJh/QLNifm7SvxO3TChgXPftofoNcT5DrH7ksY3AfmknkJTjny29wjN16s=
In-reply-to: <Pine.LNX.4.64.0711151744580.31039@anakin>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <473C720B.7000100@gmail.com> <Pine.LNX.4.64.0711151744580.31039@anakin>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.5 (X11/20070719)
Geert Uytterhoeven wrote:
> On Thu, 15 Nov 2007, Franck Bui-Huu wrote:
>>  I put the out of line version of memset in kernel/mips_ksym.c. I
>>  haven't found a better place. But if you really think we should
>>  create a lib/memset.c and rename lib/memset.S into lib/fill_user.S, I
>>  can change it.
> 
> kernel/mips_ksym.c is not a good place.

Sigh... thanks for spotting this.

So since I've no idea where I could put this function I'll follow
Thiemo's suggestion but instead of calling the new file lib/memset.c,
I'll use lib/string.c since we could move or implement other stuffs in
it.

Is it ok ?

                Franck

<Prev in Thread] Current Thread [Next in Thread>