Re: [PATCH] Introduce __fill_user() and kill __bzero()

[Thiemo Seufer <ths@networkno.de>]

Franck Bui-Huu wrote:
> Thiemo Seufer wrote:
> > In general we do (think of stack unwinding etc.).  I believe this
> > implementation should move to C, as it doesn't need an assembler
> > implementation:
> > 
> > void *memset (void *s, int c, kernel_size_t n)
> > {
> >     __fill_user(s, c, n);
> >     return s;
> > }
> > 
> > It looks much nicer that way. :-)
> > 
> 
> Sure but memset.S was a really good place to implement memset(), wasn't
> it ?

What about using memset.c and fill_user.S ?

> And since the implementation should have been trivial,

As you found out now, nothing is trivial in assembler. :-)

> I thought it was ok to implement in assembly.

As a general rule, assembly should only be used when C doesn't cut it.


Thiemo