linux-mips
[Top] [All Lists]

Re: [PATCH] Introduce __fill_user() and kill __bzero()

To: Thiemo Seufer <ths@networkno.de>
Subject: Re: [PATCH] Introduce __fill_user() and kill __bzero()
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Wed, 14 Nov 2007 13:34:26 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; bh=L4ZWNm9CS0TIPtCphL9PcZWzzLlJTsrXCIPOndF6TeM=; b=UiKq1F3KoZY/D6W7ILacMgAajmlK7KiZI0AclyWGfHocx9l686sAp7mQsH0hI8OFcPjfXD3MyHri1sZFxOUVR5zxcILaSDAWc/WbcbmK35pBgfvvqDGa1+hf4BhcfT3VGQKZUNhv3hgYPRh2LGwIRYVbUw8gABTebeRBWQQYuBQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=RUE+s1wvDlOed4b198HJ76I5dmJsflqdqpGCEPNxshmtjWD2/DGq/zNmwpsPaGs9pN56kg77SxEs162QVw3MdnmcJBFyZU/dkPZPcA/rrrmC18zN+YOtUjNLPJ5VtOuH8mmUh9j+nSmWvMQy1Y8IkrDkUxViNMdH8IgTUy6lGjc=
In-reply-to: <20071114115807.GL8363@networkno.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4736C1EA.2050009@gmail.com> <20071111130130.GB8363@networkno.de> <473AB0B6.2070208@gmail.com> <20071114115807.GL8363@networkno.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.5 (X11/20070719)
Thiemo Seufer wrote:
> In general we do (think of stack unwinding etc.).  I believe this
> implementation should move to C, as it doesn't need an assembler
> implementation:
> 
> void *memset (void *s, int c, kernel_size_t n)
> {
>       __fill_user(s, c, n);
>       return s;
> }
> 
> It looks much nicer that way. :-)
> 

Sure but memset.S was a really good place to implement memset(), wasn't
it ?

And since the implementation should have been trivial, I thought it was
ok to implement in assembly.

Ok, I'll look for another place.

Thanks,
                Franck

<Prev in Thread] Current Thread [Next in Thread>