linux-mips
[Top] [All Lists]

Re: [PATCH][au1000] Remove useless EXTRA_CFLAGS

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH][au1000] Remove useless EXTRA_CFLAGS
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 8 Nov 2007 11:25:03 +0000 (GMT)
Cc: Florian Fainelli <florian.fainelli@telecomint.eu>, linux-mips@linux-mips.org
In-reply-to: <20071108094708.GA10665@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200710252108.43357.florian.fainelli@telecomint.eu> <20071029151010.GA3953@linux-mips.org> <Pine.LNX.4.64N.0711071239560.14970@blysk.ds.pg.gda.pl> <20071108094708.GA10665@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 8 Nov 2007, Ralf Baechle wrote:

> >  Yeah...  If only GCC had no bugs and always had a clue of what to warn 
> > about...
> 
> The least of all problems.

 It depends for whom I suppose. ;-)  It is a pain when you have to stretch 
your imagination to rewrite a piece of source code GCC warns about unduly 
and both keep it readable and not make the generated binary worse...  
Especially where configuration-specific macros are involved.

> As of 2.6.20-rc2-git2 we had 137 warnings in MIPS specific code of a total
> of 218 for the kernel and 44 for modules - that's a insane 52%.  And people
> happily added more crappy code because they didn't not even _notice_ the
> warnings some of which indeed were bugs.

 Well, adding no warnings should be the rule #1 and I can understand it is 
easier for you to enforce it by the means of -Werror. ;-)

  Maciej

<Prev in Thread] Current Thread [Next in Thread>