linux-mips
[Top] [All Lists]

Re: [PATCH] Kill __bzero()

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] Kill __bzero()
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Sun, 04 Nov 2007 21:02:56 +0100
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; bh=773ZBL/AJovEwPAGlxLJafYre52Kq2ruKRg+HmH4sOg=; b=khg2A+zXFJOj1cQvu9zY9ZrpaEDXHdq+UsM+dHc8HL1BP4Hg80MgRHMRcDSZi3+Y2hCsI6pikhbV1FM598RFkhyZtESZK71BQyNN9VgaXPDDvhhkL9CiR2ZQBwOXusTbFslWpnbmrp0yx7lN0KzsdiMJmGRuTlz1cFWqqaficX4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=I/Ehm+gkbvkSDpP1WpMgSfdx6qNIq8Y3iD/YX2PO7H61t2vCdOn7s+ulRpLsuqruemT/HRAnRV34B3bxUr0hy3lIn0j84n9iQIzIBdWO8fyzgjosGtOnbEBQEd7QvXppHMmTPKPvSIhqX4LluTzeAm5Lim7lOOL9WiIaQ8/AzQU=
In-reply-to: <20071105.004208.74752504.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <472D8058.5080209@gmail.com> <20071105.004208.74752504.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.5 (X11/20070719)
Atsushi Nemoto wrote:
> On Sun, 04 Nov 2007 09:18:32 +0100, Franck Bui-Huu <fbuihuu@gmail.com> wrote:
>>   2/ For the caller, it makes no difference to call memset instead
>>   since it has to setup the second parameter of __bzero to 0.
> 
> __bzero() does not clobber v0 but memset() does.  I don't know if gcc
> does some magical thing to protect v0, but it would be safer to add v0
> explicitly to clobber-list of __clear_user().
> 

good catch ! I'll do it.

thanks
                Franck

<Prev in Thread] Current Thread [Next in Thread>