linux-mips
[Top] [All Lists]

Re: [PATCH] Put cast inside macro instead of all the callers

To: Andrew Sharp <andy.sharp@onstor.com>
Subject: Re: [PATCH] Put cast inside macro instead of all the callers
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 1 Nov 2007 17:16:40 +0000
Cc: linux-mips <linux-mips@linux-mips.org>
In-reply-to: <20071031141124.185599da@ripper.onstor.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20071031141124.185599da@ripper.onstor.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Wed, Oct 31, 2007 at 02:11:24PM -0700, Andrew Sharp wrote:

> Resend: I tried sending this a couple of days ago but haven't seen it.
> Wondering if it got stuck in a spam filter or our lovely exchange
> server or something.

It seems the list's spam filter has developed some appetite for patches,
I'm afraid.  Generally please cc me on patches.

> Since all the callers of the PHYS_TO_XKPHYS macro call with a constant,
> put the cast to LL inside the macro where it really should be rather
> than in all the callers.  This makes macros like PHYS_TO_XKSEG_UNCACHED
> work without gcc whining.
> 
> Hopefully this will apply ok.

I'm afraid, no, the definition of PHYS_TO_XKPHYS did change 3 weeks ago ...

Anyway, I fixed that up and queued it for 2.6.25.

Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>