linux-mips
[Top] [All Lists]

Re: [IDE] Fix build bug

To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [IDE] Fix build bug
From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Tue, 30 Oct 2007 11:34:29 +0000
Cc: Ralf Baechle <ralf@linux-mips.org>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-mips@linux-mips.org, Martijn Uffing <mp3project@sarijopen.student.utwente.nl>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=beta; h=domainkey-signature:received:received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; bh=UwOZDxLnm3czz5Rq/C3p23GQ/mGYn7AdmUkWc12Gr6Q=; b=cUFeqm5vYi2w/YasPIRN9M59LwOeyryHyDJW6wIRSxOqtWtEwS6ahBe3KTC4awtyCVQegGA7Itqu4iLzSu7e3OSQyMxSBS5dlNeoHWDeXyP6MOgGozMZ5yFjn7c0Y5fWBYYhxWie2nFkIjQBXoFS8DZ+Mz0TeVb6lDsylUIcbmk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=beta; h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=aMiRP1tzXYdwBbBgy3rX4NDArsMVTiJN0fFQNIV3gd79lDtjZ1eQi5UQ80lCbT+T+/+RHHMCqIb3oE3XguIcsMrh9vM6pnqpNkGG15N1NS56wqB1l9A1i7uMU83F6141csf6KuN5Gp5WxkeGcjLCHwdOp+r+kI3T2pNkObWg4l0=
In-reply-to: <200710252341.38902.bzolnier@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20071025135334.GA23272@linux-mips.org> <200710252341.38902.bzolnier@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.1
On Thursday 25 October 2007 22:41, Bartlomiej Zolnierkiewicz wrote:
> > -static const struct ide_port_info generic_chipsets[] __devinitdata = {
> > +static struct ide_port_info generic_chipsets[] __devinitdata = {
> >     /*  0 */ DECLARE_GENERIC_PCI_DEV("Unknown",     0),
> >  
> >     {       /* 1 */
> 
> I would prefer to not remove const from generic_chipsets[] so:
> 
> [PATCH] drivers/ide/pci/generic: fix build for CONFIG_HOTPLUG=n
> 
> It turns out that const and __{dev}initdata cannot be mixed currently
> and that generic IDE PCI host driver is also affected by the same issue:
> 
> On Thursday 25 October 2007, Ralf Baechle wrote:
> >   CC      drivers/ide/pci/generic.o
> > drivers/ide/pci/generic.c:52: error: __setup_str_ide_generic_all_on causes a
> > +section type conflict
> 
> [ Also reported by Martijn Uffing <mp3project@sarijopen.student.utwente.nl>. ]
> 
> This patch workarounds the problem in a bit hackish way but without
> removing const from generic_chipsets[] (it adds const to __setup() so
> __setup_str_ide_generic_all becomes const).

You wouldn't believe how much const data is not marked as const because
we don't have __constinitdata etc. Literally megabytes.
--
vda

<Prev in Thread] Current Thread [Next in Thread>