linux-mips
[Top] [All Lists]

Re: [PATCH] store sign-extend register values for PTRACE_GETREGS

To: Daniel Jacobowitz <dan@debian.org>
Subject: Re: [PATCH] store sign-extend register values for PTRACE_GETREGS
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 29 Oct 2007 18:31:27 +0000
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org
In-reply-to: <20071028195211.GA29200@caradoc.them.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070304.024152.96687132.anemo@mba.ocn.ne.jp> <20071026.005302.25909293.anemo@mba.ocn.ne.jp> <20071028193421.GC7661@linux-mips.org> <20071028195211.GA29200@caradoc.them.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Sun, Oct 28, 2007 at 03:52:11PM -0400, Daniel Jacobowitz wrote:

> On Sun, Oct 28, 2007 at 07:34:21PM +0000, Ralf Baechle wrote:
> > On Fri, Oct 26, 2007 at 12:53:02AM +0900, Atsushi Nemoto wrote:
> > 
> > Daniel, do you see any debugger compatibility issues with this patch?
> 
> I don't think so; I'm pretty sure I wrote the code at fault here,
> and I can't remember any reason I would have deliberately made the
> registers unsigned.  Looking at the fix I think I just guessed
> wrong about the type used by __put_user.

Good.  So I just applied it.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>