linux-mips
[Top] [All Lists]

Re: [PATCH] store sign-extend register values for PTRACE_GETREGS

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, Daniel Jacobowitz <dan@debian.org>
Subject: Re: [PATCH] store sign-extend register values for PTRACE_GETREGS
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sun, 28 Oct 2007 19:34:21 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <20071026.005302.25909293.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070304.024152.96687132.anemo@mba.ocn.ne.jp> <20071026.005302.25909293.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Fri, Oct 26, 2007 at 12:53:02AM +0900, Atsushi Nemoto wrote:

Daniel, do you see any debugger compatibility issues with this patch?

> From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> Date: Fri, 26 Oct 2007 00:53:02 +0900 (JST)
> To: linux-mips@linux-mips.org
> Cc: ralf@linux-mips.org
> Subject: Re: [PATCH] store sign-extend register values for PTRACE_GETREGS
> Content-Type: Text/Plain; charset=us-ascii
> 
> On Sun, 04 Mar 2007 02:41:52 +0900 (JST), Atsushi Nemoto 
> <anemo@mba.ocn.ne.jp> wrote:
> > A comment on ptrace_getregs() states "Registers are sign extended to
> > fill the available space." but it is not true.  Fix code to match the
> > comment.  Also fix casts on each caller to get rid of some warnings.
> 
> Revised for current git tree.
> 
> ------------------------------------------------------
> Subject: [PATCH] store sign-extend register values for PTRACE_GETREGS
> From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> 
> A comment on ptrace_getregs() states "Registers are sign extended to
> fill the available space." but it is not true.  Fix code to match the
> comment.  Also fix casts on each caller to get rid of some warnings.
> 
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
>  arch/mips/kernel/ptrace.c   |   18 +++++++++---------
>  arch/mips/kernel/ptrace32.c |    4 ++--
>  2 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/mips/kernel/ptrace.c b/arch/mips/kernel/ptrace.c
> index 999f785..35234b9 100644
> --- a/arch/mips/kernel/ptrace.c
> +++ b/arch/mips/kernel/ptrace.c
> @@ -65,13 +65,13 @@ int ptrace_getregs(struct task_struct *child, __s64 
> __user *data)
>       regs = task_pt_regs(child);
>  
>       for (i = 0; i < 32; i++)
> -             __put_user(regs->regs[i], data + i);
> -     __put_user(regs->lo, data + EF_LO - EF_R0);
> -     __put_user(regs->hi, data + EF_HI - EF_R0);
> -     __put_user(regs->cp0_epc, data + EF_CP0_EPC - EF_R0);
> -     __put_user(regs->cp0_badvaddr, data + EF_CP0_BADVADDR - EF_R0);
> -     __put_user(regs->cp0_status, data + EF_CP0_STATUS - EF_R0);
> -     __put_user(regs->cp0_cause, data + EF_CP0_CAUSE - EF_R0);
> +             __put_user((long)regs->regs[i], data + i);
> +     __put_user((long)regs->lo, data + EF_LO - EF_R0);
> +     __put_user((long)regs->hi, data + EF_HI - EF_R0);
> +     __put_user((long)regs->cp0_epc, data + EF_CP0_EPC - EF_R0);
> +     __put_user((long)regs->cp0_badvaddr, data + EF_CP0_BADVADDR - EF_R0);
> +     __put_user((long)regs->cp0_status, data + EF_CP0_STATUS - EF_R0);
> +     __put_user((long)regs->cp0_cause, data + EF_CP0_CAUSE - EF_R0);
>  
>       return 0;
>  }
> @@ -390,11 +390,11 @@ long arch_ptrace(struct task_struct *child, long 
> request, long addr, long data)
>               }
>  
>       case PTRACE_GETREGS:
> -             ret = ptrace_getregs(child, (__u64 __user *) data);
> +             ret = ptrace_getregs(child, (__s64 __user *) data);
>               break;
>  
>       case PTRACE_SETREGS:
> -             ret = ptrace_setregs(child, (__u64 __user *) data);
> +             ret = ptrace_setregs(child, (__s64 __user *) data);
>               break;
>  
>       case PTRACE_GETFPREGS:
> diff --git a/arch/mips/kernel/ptrace32.c b/arch/mips/kernel/ptrace32.c
> index f2bffed..76818be 100644
> --- a/arch/mips/kernel/ptrace32.c
> +++ b/arch/mips/kernel/ptrace32.c
> @@ -346,11 +346,11 @@ asmlinkage int sys32_ptrace(int request, int pid, int 
> addr, int data)
>               }
>  
>       case PTRACE_GETREGS:
> -             ret = ptrace_getregs(child, (__u64 __user *) (__u64) data);
> +             ret = ptrace_getregs(child, (__s64 __user *) (__u64) data);
>               break;
>  
>       case PTRACE_SETREGS:
> -             ret = ptrace_setregs(child, (__u64 __user *) (__u64) data);
> +             ret = ptrace_setregs(child, (__s64 __user *) (__u64) data);
>               break;
>  
>       case PTRACE_GETFPREGS:

  Ralf

<Prev in Thread] Current Thread [Next in Thread>