| To: | Thiemo Seufer <ths@networkno.de> |
|---|---|
| Subject: | Re: [PATCH] Fix/Rewrite of the mipsnet driver |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Mon, 29 Oct 2007 00:25:17 +0000 |
| Cc: | linux-mips@linux-mips.org, netdev@vger.kernel.org |
| In-reply-to: | <20071028043846.GM29176@networkno.de> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20071028043846.GM29176@networkno.de> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.14 (2007-02-12) |
On Sun, Oct 28, 2007 at 04:38:46AM +0000, Thiemo Seufer wrote: > Hello All, > > currently the mipsnet driver fails after transmitting a number of > packages because SKBs are allocated but never freed. I fixed that > and coudn't refrain from removing the most egregious warts. > > - mipsnet.h folded into mipsnet.c, as it doesn't provide any > useful external interface. > - Free SKB after transmission. > - Call free_irq in mipsnet_close, to balance the request_irq in > mipsnet_open. > - Removed duplicate read of rxDataCount. > - Some identifiers are now less verbose. > - Removed dead and/or unnecessarily complex code. > - Code formatting fixes. > > Tested on Qemu's mipssim emulation, with this patch it can boot a > Debian NFSroot. The patch does no longer apply to a recent tree, can you respin it? Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Use a sensible tlbex default for unknown CPUs, Ralf Baechle |
|---|---|
| Next by Date: | 2.6.24-rc1 does not boot on SGI [was: Re: 2.4.24-rc1 does not boot on SGI], Giuseppe Sacco |
| Previous by Thread: | [PATCH] Fix/Rewrite of the mipsnet driver, Thiemo Seufer |
| Next by Thread: | Re: [PATCH] Fix/Rewrite of the mipsnet driver, Thiemo Seufer |
| Indexes: | [Date] [Thread] [Top] [All Lists] |