linux-mips
[Top] [All Lists]

Re: [PATCH 3/4] vmlinux.ld.S: correctly indent .data section

To: Andrew Sharp <andy.sharp@onstor.com>
Subject: Re: [PATCH 3/4] vmlinux.ld.S: correctly indent .data section
From: Franck Bui-Huu <fbuihuu@gmail.com>
Date: Fri, 19 Oct 2007 09:54:44 +0200
Cc: macro@linux-mips.org, linux-mips <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; bh=rGIx6co7MfRglut91XpAkkHsnk/GQOlUFHMOwKYxBEo=; b=j5bQP3fQTI9zbq8XIIb4jgJL/13y6vJ+p7H9T+ShmZEdE3fV/Z1LbANqjLbbWLTK0zz1Gl69bCMFhFoam4sjCjIoh5yRBA2BN7iKh/U/CgmN+nJay5g5BzdC1YqqfpSWgZE7FtAzXuyrFGlYN5gP3gkVKz5ZZ/IDZKuTtdNrb3g=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=QsGb+tqDAtf38tfujHHV+4DA0G7NW0H6kyaIU2tOzP1bF4UiM3RbMIUN1xi4WZJCKPVRovCQmwjG8VmfRi4mlL2OKdIgKKAz3w1thhSfg8BjMkBw+09EFRDEOJuZMDKjnN3NfEn0/UFHfbin8zXQwkgAyyz4bBDQB8Y7ihQa3wE=
In-reply-to: <20071018145723.4e4153c1@ripper.onstor.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1192741953-7040-1-git-send-email-fbuihuu@gmail.com> <1192741953-7040-4-git-send-email-fbuihuu@gmail.com> <20071018145723.4e4153c1@ripper.onstor.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.5 (X11/20070719)
Andrew Sharp wrote:
> On Thu, 18 Oct 2007 23:12:32 +0200 Franck Bui-Huu <fbuihuu@gmail.com>
> wrote:
> 
>> Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
>> ---
>>  arch/mips/kernel/vmlinux.lds.S |   32
>> +++++++++++++++++--------------- 1 files changed, 17 insertions(+),
>> 15 deletions(-)
>>
>> diff --git a/arch/mips/kernel/vmlinux.lds.S
>> b/arch/mips/kernel/vmlinux.lds.S index e0a4dc0..2f6c225 100644
>> --- a/arch/mips/kernel/vmlinux.lds.S
>> +++ b/arch/mips/kernel/vmlinux.lds.S
>> @@ -55,21 +55,23 @@ SECTIONS
>>  
>>      /* writeable */
>>      .data : {       /* Data */
>> -      . = . + DATAOFFSET;           /* for
>> CONFIG_MAPPED_KERNEL */
>> -      /*
>> -       * This ALIGN is needed as a workaround for a bug a gcc
>> bug upto 4.1 which
>> -       * limits the maximum alignment to at most 32kB and
>> results in the following
>> -       * warning:
>> -       *
>> -       *  CC      arch/mips/kernel/init_task.o
>> -       * arch/mips/kernel/init_task.c:30: warning: alignment of
>> â??init_thread_unionâ??
>> -       * is greater than maximum object file alignment.  Using
>> 32768
>> -       */
>> -      . = ALIGN(_PAGE_SIZE);
>> -      *(.data.init_task)
>> -
>> -      DATA_DATA
>> -      CONSTRUCTORS
>> +            . = . + DATAOFFSET;             /* for
>> CONFIG_MAPPED_KERNEL */
>> +            /*
>> +             * This ALIGN is needed as a workaround for a bug a
>> +             * gcc bug upto 4.1 which limits the maximum
> 
> at least fix the text while you're here: 'a bug a gcc bug'
> 
>> +             * to at most 32kB and results in the following
>> +             * warning:
>> +             *
>> +             *  CC      arch/mips/kernel/init_task.o
>> +             * arch/mips/kernel/init_task.c:30: warning:
>> alignment
>> +             * of â??init_thread_unionâ?? is greater than maximum
> 
> is that utf-8 or something?  probably should remove that.
> 
> sorry for the picayunes, but hey as long as you're here changing the
> indenting ~:^)
> 
> 

Okay I'll fix them.

Thanks
                Franck

<Prev in Thread] Current Thread [Next in Thread>