linux-mips
[Top] [All Lists]

Re: plat_timer_setup, mips_timer_ack, etc.

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: plat_timer_setup, mips_timer_ack, etc.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 17 Oct 2007 17:28:37 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20071017.020113.63743059.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20071017.005211.108739735.anemo@mba.ocn.ne.jp> <20071016163610.GA25794@linux-mips.org> <20071017.020113.63743059.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Wed, Oct 17, 2007 at 02:01:13AM +0900, Atsushi Nemoto wrote:

> On Tue, 16 Oct 2007 17:36:10 +0100, Ralf Baechle <ralf@linux-mips.org> wrote:
> > > Also I found mips_timer_ack and cycles_per_jiffy are not used now.
> > > Can we remove them entirely?
> > 
> > I think so.  Each clockevent device should rather try to be independent
> > of others.  What made the old timer code such a mess is that it was
> > desparately trying to share resources giving everybody plenty of rope ...
> 
> So all mips_timer_ack users should implement its own clockevent
> device, right?

Yes.

> $ git-grep mips_timer_ack arch/mips
> arch/mips/dec/time.c:   mips_timer_ack = dec_timer_ack;
> arch/mips/jmr3927/rbhma3100/setup.c:    mips_timer_ack = jmr3927_timer_ack;
> arch/mips/philips/pnx8550/common/time.c:        mips_timer_ack = timer_ack;
> arch/mips/sni/time.c:        mips_timer_ack = sni_a20r_timer_ack;

Not too many then I guess ;-)

  Ralf

<Prev in Thread] Current Thread [Next in Thread>