Re: [PATCH 1/4] tlbex.c: Cleanup __init usages.

[Franck Bui-Huu <vagabon.xyz@gmail.com>]

Atsushi Nemoto wrote:
> On Fri, 12 Oct 2007 08:41:18 +0200, Franck Bui-Huu <fbuihuu@gmail.com> wrote:
>>  #define I_0(op)                                                     \
>> -    static inline void __init i##op(u32 **buf)              \
>> +    static inline void i##op(u32 **buf)             \
>>      {                                                       \
>>              build_insn(buf, insn##op);                      \
>>      }
> 
> This causes section mismatches, since i_tlbwr and i_tlbwi can not be
> inlined (see head of build_tlb_write_entry()).
> 

You're right. I compiled tlbex.o alone and missed that.

> Maybe __init __maybe_unused is preferred?
> 

Yes I'll do that.

Thanks,
                Franck