linux-mips
[Top] [All Lists]

Re: [PATCH 1/4] tlbex.c: Cleanup __init usages.

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 1/4] tlbex.c: Cleanup __init usages.
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Sun, 14 Oct 2007 21:24:03 +0200
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; bh=dVQzCWFPkDhqmR4szy5u5H6O/G62/S7fq5Q/omABvgg=; b=M9/HO/tVnY6P61Cszs1fFFj1JWAmAUXPfFPRhXhuaqfxDpdbOMTQSiiHUFMrsNt/7JLS54OZTrcXlLqUEtuP4U5tUAa9l5Bvj1IK6rcMcBRvm4iDB4ZzUcSY7You/0FSfNsQd2FNw2yFQaYZITstmXj4NAAQaWF7+dRRxwZ6VN4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=dX8FBsTK2TuFbEPp4mFNrdCfxqByn6AWK05kjHe1X1NTZVTZzlx5OW/nE9UhqEzRZUOvrR46cNUmtiT7Av2zaHDo0888y8R161V765K7Uj9Kc4cczt0mPrACPG3fmx+ce1xLrK7KJjhyvWHO8Lmotu1dJFShYanUe52H2Px6CIM=
In-reply-to: <20071012.180742.59650681.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <470F16B9.7030406@gmail.com> <470F170E.1060303@gmail.com> <20071012.180742.59650681.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.5 (X11/20070719)
Atsushi Nemoto wrote:
> On Fri, 12 Oct 2007 08:41:18 +0200, Franck Bui-Huu <fbuihuu@gmail.com> wrote:
>>  #define I_0(op)                                                     \
>> -    static inline void __init i##op(u32 **buf)              \
>> +    static inline void i##op(u32 **buf)             \
>>      {                                                       \
>>              build_insn(buf, insn##op);                      \
>>      }
> 
> This causes section mismatches, since i_tlbwr and i_tlbwi can not be
> inlined (see head of build_tlb_write_entry()).
> 

You're right. I compiled tlbex.o alone and missed that.

> Maybe __init __maybe_unused is preferred?
> 

Yes I'll do that.

Thanks,
                Franck


<Prev in Thread] Current Thread [Next in Thread>