linux-mips
[Top] [All Lists]

Re: [PATCH 1/4] tlbex.c: Cleanup __init usages.

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 1/4] tlbex.c: Cleanup __init usages.
From: Johannes Dickgreber <tanzy@gmx.de>
Date: Fri, 12 Oct 2007 18:01:14 +0200
Cc: fbuihuu@gmail.com, ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20071012.180742.59650681.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <470F16B9.7030406@gmail.com> <470F170E.1060303@gmail.com> <20071012.180742.59650681.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.12 (X11/20060911)
Atsushi Nemoto schrieb:
> On Fri, 12 Oct 2007 08:41:18 +0200, Franck Bui-Huu <fbuihuu@gmail.com> wrote:
>>  #define I_0(op)                                                     \
>> -    static inline void __init i##op(u32 **buf)              \
>> +    static inline void i##op(u32 **buf)             \
>>      {                                                       \
>>              build_insn(buf, insn##op);                      \
>>      }
> 
> This causes section mismatches, since i_tlbwr and i_tlbwi can not be
> inlined (see head of build_tlb_write_entry()).
> 
> Maybe __init __maybe_unused is preferred?
> 
> ---
> Atsushi Nemoto
> 

Hi

I got the error too.

If build_tlb_write_entry() is inlined it doesent happen.

But as it is already reverted maybe it is not so importent.

bye tanzy

<Prev in Thread] Current Thread [Next in Thread>