linux-mips
[Top] [All Lists]

Re: [PATCH 2/6] tlbex.c: Remove relocs[] and labels[] from the init.data

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 2/6] tlbex.c: Remove relocs[] and labels[] from the init.data section
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 10 Oct 2007 18:55:45 +0200 (CEST)
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>, Franck Bui-Huu <fbuihuu@gmail.com>, Thiemo Seufer <ths@networkno.de>, linux-mips@linux-mips.org
In-reply-to: <20071010164236.GB10243@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4703F155.4000301@gmail.com> <20071003201800.GP16772@networkno.de> <47049734.6050802@gmail.com> <20071004121557.GA28928@linux-mips.org> <4705004C.5000705@gmail.com> <20071005115151.GA16145@linux-mips.org> <470BE58A.9070709@gmail.com> <470BE61F.5020108@gmail.com> <20071010142755.GA9325@linux-mips.org> <Pine.LNX.4.64N.0710101715380.9821@blysk.ds.pg.gda.pl> <20071010164236.GB10243@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 10 Oct 2007, Ralf Baechle wrote:
> On Wed, Oct 10, 2007 at 05:17:24PM +0100, Maciej W. Rozycki wrote:
> > > > It increases the stack pressure a lot (more than 2500 bytes) but
> > > > at this stage in the boot process, it shouldn't matter.
> > > 
> > > Even more for 64-bit kernel - and I would really like to keep reduce
> > > the kernel stack for 64-bit kernels, THREAD_SIZE_ORDER 2 is already
> > > slightly painful when memory becomes fragmented.
> > 
> >  I think the right fix is to implement "__initbss" along the lines of 
> > "__initdata".

Or e.g. static struct label labels[128] __initdata = { 0, };
Cfr. the old rule `always initialize initdata, even if it must be 0'.

> Indeed.  Doesn't even look so hard and would likely generally be welcome.

That's a valid alternative, of course...

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>