linux-mips
[Top] [All Lists]

Re: [PATCH 2/6] tlbex.c: Remove relocs[] and labels[] from the init.data

To: Franck Bui-Huu <fbuihuu@gmail.com>
Subject: Re: [PATCH 2/6] tlbex.c: Remove relocs[] and labels[] from the init.data section
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 10 Oct 2007 15:27:55 +0100
Cc: Thiemo Seufer <ths@networkno.de>, "Maciej W. Rozycki" <macro@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <470BE61F.5020108@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <47038874.9050704@gmail.com> <20071003131158.GL16772@networkno.de> <4703F155.4000301@gmail.com> <20071003201800.GP16772@networkno.de> <47049734.6050802@gmail.com> <20071004121557.GA28928@linux-mips.org> <4705004C.5000705@gmail.com> <20071005115151.GA16145@linux-mips.org> <470BE58A.9070709@gmail.com> <470BE61F.5020108@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Tue, Oct 09, 2007 at 10:35:43PM +0200, Franck Bui-Huu wrote:

> This patch reduces the kernel image size by making these 2 arrays
> automatic variables.
> 
>       tlbex.o~old  =>  tlbex.o
>        text:     9840     9812      -28  0%
>        data:     3904     1344    -2560 -65%
>         bss:     1568     1568        0  0%
>       total:    15312    12724    -2588 -16%
> 
> It increases the stack pressure a lot (more than 2500 bytes) but
> at this stage in the boot process, it shouldn't matter.

Even more for 64-bit kernel - and I would really like to keep reduce
the kernel stack for 64-bit kernels, THREAD_SIZE_ORDER 2 is already
slightly painful when memory becomes fragmented.

The other issue is that with CPU plugging (halfbreed patches to add that
to MIPS are around) this code can be called at any time, not only during
early startup when at most a timer interrupt may strike.  Bootmem maybe?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>