| To: | Giuseppe Sacco <giuseppe@eppesuigoccas.homedns.org> |
|---|---|
| Subject: | Re: [PATCH]v2 mips/ip32: enable PCI bridges |
| From: | "Maciej W. Rozycki" <macro@linux-mips.org> |
| Date: | Mon, 8 Oct 2007 14:27:04 +0100 (BST) |
| Cc: | Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org |
| In-reply-to: | <E1IeDrj-0002u6-2B@eppesuigoccas.homedns.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <E1IeDrj-0002u6-2B@eppesuigoccas.homedns.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Sat, 6 Oct 2007, Giuseppe Sacco wrote:
> @@ -33,7 +33,7 @@ static inline int mkaddr(struct pci_bus *bus, unsigned int
> devfn,
> unsigned int reg)
> {
> return ((bus->number & 0xff) << 16) |
> - (devfn & 0xff) << 8) |
> + ((devfn & 0xff) << 8) |
> (reg & 0xfc);
> }
Bad formatting -- using correct one would make the typo more obvious
(ditto about the function's header).
Maciej
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH][MIPS][5/7] AR7: watchdog timer, Wim Van Sebroeck |
|---|---|
| Next by Date: | Re: linux cache routines for Write-back cache policy on MIPS24KE, veerasena reddy |
| Previous by Thread: | Re: [PATCH]v2 mips/ip32: enable PCI bridges, Ralf Baechle |
| Next by Thread: | [PATCH] On a SGI Octane not all ARCS Memory if freed for kernel use, Johannes Dickgreber |
| Indexes: | [Date] [Thread] [Top] [All Lists] |