linux-mips
[Top] [All Lists]

Re: [PATCH][2/4] move Cobalt UART base definition to arch/mips/cobalt/co

To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Subject: Re: [PATCH][2/4] move Cobalt UART base definition to arch/mips/cobalt/console.c
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 2 Oct 2007 21:14:58 +0100
Cc: linux-mips <linux-mips@linux-mips.org>
In-reply-to: <20071002231317.0fbaf7bb.yoichi_yuasa@tripeaks.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20071002225441.63d935eb.yoichi_yuasa@tripeaks.co.jp> <20071002231317.0fbaf7bb.yoichi_yuasa@tripeaks.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Tue, Oct 02, 2007 at 11:13:17PM +0900, Yoichi Yuasa wrote:

> diff -pruN -X mips/Documentation/dontdiff 
> mips-orig/arch/mips/cobalt/console.c mips/arch/mips/cobalt/console.c
> --- mips-orig/arch/mips/cobalt/console.c      2007-09-30 21:21:39.610319250 
> +0900
> +++ mips/arch/mips/cobalt/console.c   2007-09-30 21:26:10.135226000 +0900
> @@ -1,16 +1,15 @@
>  /*
>   * (C) P. Horton 2006
>   */
> +#include <linux/io.h>
>  #include <linux/serial_reg.h>
>  
> -#include <asm/addrspace.h>
> -
> -#include <cobalt.h>
> +#define UART_BASE    ((void __iomem *)CKSEG1ADDR(0x1c800000))
>  
>  void prom_putchar(char c)
>  {
> -     while(!(COBALT_UART[UART_LSR] & UART_LSR_THRE))
> +     while(!(readb(UART_BASE + UART_LSR) & UART_LSR_THRE))
            ^^^
          missing space.

Aside of that looks ok, so I fixed that up and queued all four patches
for 2.6.24.

Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>