linux-mips
[Top] [All Lists]

Re: [i2c] [PATCH 1/4] i2c sibyte adapter driver is rewritten with 2.6.x

To: Mark Zhan <rongkai.zhan@windriver.com>
Subject: Re: [i2c] [PATCH 1/4] i2c sibyte adapter driver is rewritten with 2.6.x style binding model
From: Jean Delvare <khali@linux-fr.org>
Date: Mon, 1 Oct 2007 15:26:13 +0200
Cc: i2c@lm-sensors.org, linux-mips@linux-mips.org, rtc-linux@googlegroups.com, a.zummo@towertech.it, ralf@linux-mips.org
In-reply-to: <46FF7262.9060802@windriver.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <46FF7262.9060802@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
Hi Mark,

On Sun, 30 Sep 2007 17:54:42 +0800, Mark Zhan wrote:
> This patch re-writes the sibyte i2c adapter driver with 2.6.x style
> binding model.
> 
> Signed-off-by: Mark Zhan <rongkai.zhan@windriver.com>
> ---
>   drivers/i2c/busses/i2c-sibyte.c |  150 
> ++++++++++++++--------------------------
>   1 file changed, 55 insertions(+), 95 deletions(-)
> 
> --- a/drivers/i2c/busses/i2c-sibyte.c
> +++ b/drivers/i2c/busses/i2c-sibyte.c
> @@ -1,4 +1,5 @@
>   /*
> + * Copyright (C) 2007 Wind River Inc. Mark Zhan <rongkai.zhan@windriver.com>
>    * Copyright (C) 2004 Steven J. Hill
>    * Copyright (C) 2001,2002,2003 Broadcom Corporation
>    * Copyright (C) 1995-2000 Simon G. Vogl

Patch doesn't apply. It seems that your mailer added a leading space on
all context lines? Please address the problem and resend the patch(es).
I volunteer to review patches 1 and 2, once I can apply them.

-- 
Jean Delvare

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [i2c] [PATCH 1/4] i2c sibyte adapter driver is rewritten with 2.6.x style binding model, Jean Delvare <=