linux-mips
[Top] [All Lists]

Re: [PATCH][MIPS][7/7] AR7: ethernet

To: Matteo Croce <technoboy85@gmail.com>
Subject: Re: [PATCH][MIPS][7/7] AR7: ethernet
From: Jeff Garzik <jgarzik@pobox.com>
Date: Sat, 29 Sep 2007 01:39:19 -0400
Cc: linux-mips@linux-mips.org, Eugene Konev <ejka@imfi.kspu.ru>, netdev@vger.kernel.org, davem@davemloft.net, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@coreworks.de, Andrew Morton <akpm@linux-foundation.org>
In-reply-to: <200709201813.48408.technoboy85@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200709201728.10866.technoboy85@gmail.com> <200709201813.48408.technoboy85@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.5 (X11/20070727)
Overall, looks pretty clean, good job!

Comments:

1) [major issue] Don't take and release a heavy lock on every single RX packet.

2) remove net_device_stats from private structure, and use net_device::stats

3) rx_ring_size should not be a module param, since that should be supported via ethtool

4) cpmac_tx_timeout() doesn't really do anything to alleviate the condition

5) don't set dev->mem_start and dev->mem_end, those are fields that are going away, and that's not their intended purpose. just store a pointer to the resource info.



<Prev in Thread] Current Thread [Next in Thread>