| To: | Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org |
|---|---|
| Subject: | [PATCH] hugetlb: Fix clear_user_highpage arguments |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Fri, 28 Sep 2007 17:35:45 +0100 |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.14 (2007-02-12) |
The virtual address space argument of clear_user_highpage is supposed to
be the virtual address where the page being cleared will eventually be
mapped. This allows architectures with virtually indexed caches a few
clever tricks. That sort of trick falls over in painful ways if the
virtual address argument is wrong.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 84c795e..eab8c42 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -42,7 +42,7 @@ static void clear_huge_page(struct page *page, unsigned long
addr)
might_sleep();
for (i = 0; i < (HPAGE_SIZE/PAGE_SIZE); i++) {
cond_resched();
- clear_user_highpage(page + i, addr);
+ clear_user_highpage(page + i, addr + i * PAGE_SIZE);
}
}
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] sb1250-mac: Driver model & phylib update, Maciej W. Rozycki |
|---|---|
| Next by Date: | Re: [PATCH] Fix fallocate on mips64 o32 ABI, Ralf Baechle |
| Previous by Thread: | Tests of 2.6.23-rc8 on SGI O2, Giuseppe Sacco |
| Next by Thread: | Re: [PATCH] hugetlb: Fix clear_user_highpage arguments, Andrew Morton |
| Indexes: | [Date] [Thread] [Top] [All Lists] |