linux-mips
[Top] [All Lists]

Re: [tglx@linutronix.de: [PATCH] clockevents: fix bogus next_event reset

To: linux-mips@linux-mips.org
Subject: Re: [tglx@linutronix.de: [PATCH] clockevents: fix bogus next_event reset for oneshot broadcast devices]
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 28 Sep 2007 13:47:24 +0100
In-reply-to: <20070927221956.GA19990@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070927221956.GA19990@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Thu, Sep 27, 2007 at 11:19:56PM +0100, Ralf Baechle wrote:

> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Fri, 28 Sep 2007 00:17:04 +0200
> To: LKML <linux-kernel@vger.kernel.org>
> Cc: Andrew Morton <akpm@osdl.org>, Ralf Baechle <ralf@linux-mips.org>
> Subject: [PATCH] clockevents: fix bogus next_event reset for oneshot
>       broadcast devices
> Content-Type: text/plain
> 
> In periodic broadcast mode the next_event member of the broadcast device
> structure is set to KTIME_MAX in the interrupt handler. This is wrong,
> as we calculate the next periodic interrupt with this variable.
> 
> Remove it.
> 
> Noticed by Ralf. MIPS is the first user of this mode, it does not affect
> existing users.

Which is a different from what I was using, so that throws somewhat of a
wrench into some of the MIPS dyntick mechanics.  But it doesn't change
the fact that this fix is correct.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>