linux-mips
[Top] [All Lists]

Re: [PATCH][5/6] led: add Cobalt Qube series front LED support to platfo

To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Subject: Re: [PATCH][5/6] led: add Cobalt Qube series front LED support to platform register
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 20 Sep 2007 17:40:20 +0100
Cc: Richard Purdie <rpurdie@rpsys.net>, linux-mips <linux-mips@linux-mips.org>
In-reply-to: <20070920230841.5e4b0a05.yoichi_yuasa@tripeaks.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070920230204.0ad15513.yoichi_yuasa@tripeaks.co.jp> <20070920230322.6600dd83.yoichi_yuasa@tripeaks.co.jp> <20070920230513.1dbb1d6d.yoichi_yuasa@tripeaks.co.jp> <20070920230656.640886f5.yoichi_yuasa@tripeaks.co.jp> <20070920230841.5e4b0a05.yoichi_yuasa@tripeaks.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Thu, Sep 20, 2007 at 11:08:41PM +0900, Yoichi Yuasa wrote:

> Add Cobalt Qube series front LED support to platform register.
> 
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> 
> diff -pruN -X mips/Documentation/dontdiff mips-orig/arch/mips/cobalt/led.c 
> mips/arch/mips/cobalt/led.c
> --- mips-orig/arch/mips/cobalt/led.c  2007-09-12 13:48:40.740621250 +0900
> +++ mips/arch/mips/cobalt/led.c       2007-09-12 13:47:59.474042250 +0900
> @@ -22,6 +22,8 @@
>  #include <linux/ioport.h>
>  #include <linux/platform_device.h>
>  
> +#include <cobalt.h>
> +
>  static struct resource cobalt_led_resource __initdata = {
>       .start  = 0x1c000000,
>       .end    = 0x1c000000,
> @@ -33,7 +35,11 @@ static __init int cobalt_led_add(void)
>       struct platform_device *pdev;
>       int retval;
>  
> -     pdev = platform_device_alloc("Cobalt Raq LEDs", -1);
> +     if (cobalt_board_id == COBALT_BRD_ID_QUBE1 ||
> +         cobalt_board_id == COBALT_BRD_ID_QUBE2)
> +             pdev = platform_device_alloc("Cobalt Qube LEDs", -1);
> +     else
> +             pdev = platform_device_alloc("Cobalt Raq LEDs", -1);

Same thing - can you make that string something all lowercase without
spaces?

>  
>       if (!pdev)
>               return -ENOMEM;

  Ralf

<Prev in Thread] Current Thread [Next in Thread>