linux-mips
[Top] [All Lists]

Re: [PATCH] kernel/process.c: R3000 setup for kernel_thread()

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] kernel/process.c: R3000 setup for kernel_thread()
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 18 Sep 2007 19:05:21 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <Pine.LNX.4.64N.0709181834420.18665@blysk.ds.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.64N.0709181834420.18665@blysk.ds.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Tue, Sep 18, 2007 at 06:49:08PM +0100, Maciej W. Rozycki wrote:

>  Match the R4000 semantics for the initial state of interrupt/kernel
> status register flags for the R3000 in kernel_thread().
> 
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
>  The R4000 variation preserves the interrupt/kernel status flags; the 
> R3000 assumes a certain state.  It may not matter, at least at the current 
> state of the code, but for consistency I think the R3000 variation should 
> do the same as the R4000 one, first for purity and second because there is 
> less maintenance force available for the R3000 and any discrepancy between 
> the two variations means a greater chance for subtle bugs.  The 
> performance hit is negligible.

Since it doesn't seem to bite I queued this for 2.6.24.  Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>